Remove custom Surefire provider #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## master #1598 +/- ##
============================================
- Coverage 92.07% 91.94% -0.14%
+ Complexity 3561 3491 -70
============================================
Files 325 321 -4
Lines 8510 8329 -181
Branches 742 722 -20
============================================
- Hits 7836 7658 -178
+ Misses 502 500 -2
+ Partials 172 171 -1Continue to review full report at Codecov.
|
marcphilipp
requested changes
Sep 25, 2018
LICENSE.md
Outdated
| @@ -3,7 +3,6 @@ Open Source Licenses | |||
|
|
|||
| The individual JUnit modules/artifacts use different open source licenses: | |||
|
|
|||
| - `junit-platform-surefire-provider` uses [Apache License v2.0](junit-platform-surefire-provider/LICENSE.md) | |||
| - All other modules use [Eclipse Public License v2.0](junit-jupiter-api/LICENSE.md). | |||
| - All modules use [Eclipse Public License v2.0](junit-jupiter-api/LICENSE.md). | |||
There was a problem hiding this comment.
I think we should just replace this file with the EPL v2 now.
| @@ -209,7 +209,7 @@ additional dependency to the runtime classpath. | |||
| ==== Maven | |||
|
|
|||
| NOTE: The custom `junit-platform-surefire-provider`, which was originally developed by | |||
| the JUnit team, has been deprecated and is scheduled to be removed in JUnit Platform 1.4. | |||
| the JUnit team, is removed from JUnit Platform 1.4. | |||
sormuras
force-pushed
the
issues/1597-remove-surefire-provider
branch
from
532e83f
to
3b75241
Compare
|
@marcphilipp Anything else to erase? |
marcphilipp
requested changes
Sep 26, 2018
build.gradle
Outdated
| : 'EPL-2.0' | ||
| ] | ||
| } | ||
| licenseOf = { project -> licenses['EPL-2.0'] } |
There was a problem hiding this comment.
we only need license now
license = [
name: 'Eclipse Public License v2.0',
url: 'http://www.eclipse.org/legal/epl-v20.html',
headerFile: 'eclipse-public-license-2.0.java'
]Only EPL-2.0 is used, no need to lookup a license per project. Issue #1597
|
This is it. |
marcphilipp
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #1597
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations