Always call pre-destroy callbacks if instance was created

[marcphilipp]

Prior to this commit, pre-destroy callbacks were not called when an
instance was created but post-processing it failed. Now, they are always
called if the instance was created, regardless if any subsequent step
failed.

We previously had a test that asserted the old behavior. However, IMHO
the new behavior is more consistent and changing it is ok since
TestInstancePreDestroyCallback is still experimental.

Resolves #2312.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@be2aa24). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #2316   +/-   ##
=========================================
  Coverage          ?   90.40%           
  Complexity        ?     4524           
=========================================
  Files             ?      393           
  Lines             ?    11045           
  Branches          ?      891           
=========================================
  Hits              ?     9985           
  Misses            ?      792           
  Partials          ?      268           

Impacted Files	Coverage Δ	Complexity Δ
...jupiter/engine/descriptor/ClassTestDescriptor.java	100.00% <ø> (ø)	6.00 <0.00> (?)
...r/engine/descriptor/NestedClassTestDescriptor.java	100.00% <ø> (ø)	6.00 <0.00> (?)
...er/engine/descriptor/ClassBasedTestDescriptor.java	96.80% <100.00%> (ø)	71.00 <5.00> (?)
...er/engine/descriptor/TestMethodTestDescriptor.java	97.90% <100.00%> (ø)	53.00 <4.00> (?)
...upiter/engine/execution/TestInstancesProvider.java	100.00% <100.00%> (ø)	1.00 <1.00> (?)
...upiter/engine/descriptor/LifecycleMethodUtils.java	100.00% <0.00%> (ø)	17.00% <0.00%> (?%)
...g/junit/platform/commons/util/ToStringBuilder.java	100.00% <0.00%> (ø)	7.00% <0.00%> (?%)
.../java/org/junit/platform/runner/JUnitPlatform.java	97.91% <0.00%> (ø)	47.00% <0.00%> (?%)
...ter/params/ParameterizedTestParameterResolver.java	100.00% <0.00%> (ø)	8.00% <0.00%> (?%)
...va/org/junit/jupiter/api/DisplayNameGenerator.java	100.00% <0.00%> (ø)	1.00% <0.00%> (?%)
... and 388 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be2aa24...18c27aa. Read the comment docs.

[sbrannen]

Thanks for the PR, @marcphilipp!

I reviewed the changes in the browser, and I think it's safe to say: LGTM.