-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune stack traces produced by failing tests #3277
Conversation
9de179a
to
b80a7a8
Compare
Resolves #3247 Co-authored-by: Christian Stein <sormuras@gmail.com>
e3fa37b
to
d64c80a
Compare
junit-platform-commons/src/main/java/org/junit/platform/commons/util/ExceptionUtils.java
Outdated
Show resolved
Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/util/ExceptionUtils.java
Show resolved
Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/util/ExceptionUtils.java
Show resolved
Hide resolved
...src/main/java/org/junit/platform/launcher/core/StackTracePruningEngineExecutionListener.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/junit/platform/launcher/core/StackTracePruningEngineExecutionListener.java
Outdated
Show resolved
Hide resolved
documentation/src/docs/asciidoc/release-notes/release-notes-5.10.0-M1.adoc
Outdated
Show resolved
Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/util/ExceptionUtils.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/junit/platform/launcher/core/StackTracePruningEngineExecutionListener.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/junit/platform/launcher/core/StackTracePruningEngineExecutionListener.java
Show resolved
Hide resolved
junit-platform-launcher/src/main/java/org/junit/platform/launcher/LauncherConstants.java
Show resolved
Hide resolved
junit-platform-launcher/src/main/java/org/junit/platform/launcher/LauncherConstants.java
Outdated
Show resolved
Hide resolved
junit-platform-launcher/src/main/java/org/junit/platform/launcher/LauncherConstants.java
Show resolved
Hide resolved
33a763c
to
4bf3cb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't review the code: I'm leaving that to you, Marc, and Christian for the time being.
I only made a few suggestions for the documentation.
documentation/src/docs/asciidoc/release-notes/release-notes-5.10.0-M1.adoc
Outdated
Show resolved
Hide resolved
...tform-commons/src/main/java/org/junit/platform/commons/util/ClassNamePatternFilterUtils.java
Outdated
Show resolved
Hide resolved
junit-platform-launcher/src/main/java/org/junit/platform/launcher/LauncherConstants.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me.
Resolves #3247
Co-authored-by: Christian Stein sormuras@gmail.com
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations