Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise stack trace pruning #3299

Closed
3 tasks done
juliette-derancourt opened this issue May 12, 2023 · 0 comments · Fixed by #3364
Closed
3 tasks done

Revise stack trace pruning #3299

juliette-derancourt opened this issue May 12, 2023 · 0 comments · Fixed by #3364

Comments

@juliette-derancourt
Copy link
Member

juliette-derancourt commented May 12, 2023

Context

Stack trace pruning was introduced in #3247.
We want this feature to be disabled for tests inside this repository (otherwise all stack traces would be almost empty), and it is when the tests are launched via gradle (due to this setting). But when launched in a different way, this setting have no impact and the feature is therefore enabled when it shouldn’t.

Solution

A potential solution could be to not prune stack traces of tests specifically located inside the org.junit package, even when the feature is enabled.

Related

Deliverables

  • Collect MethodSource and ClassSource instances from the current test descriptor and its parents, find the bottom-most stackframe with one of these classes, and include all stackframe upward from there
  • Don't prune everything from java.* and jdk.*, just the reflection packages from both but only below the test method
  • Remove package pattern configuration parameter introduced in M1
@juliette-derancourt juliette-derancourt changed the title ## Context Stack trace pruning should be disabled for tests inside org.junit package May 12, 2023
@juliette-derancourt juliette-derancourt added this to the 5.10 RC1 milestone May 12, 2023
@juliette-derancourt juliette-derancourt self-assigned this May 12, 2023
@marcphilipp marcphilipp changed the title Stack trace pruning should be disabled for tests inside org.junit package Revise stack trace pruning May 26, 2023
juliette-derancourt added a commit that referenced this issue Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants