Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use module version of Console Launcher when on module path #3847

Merged

Conversation

marcphilipp
Copy link
Member

Fixes #3827.


Definition of Done

@marcphilipp marcphilipp self-assigned this Jun 6, 2024
@marcphilipp marcphilipp force-pushed the marc/3827-fix-console-launcher-version-on-module-path branch from 940304a to a0bedd5 Compare June 6, 2024 10:25
@marcphilipp marcphilipp force-pushed the marc/3827-fix-console-launcher-version-on-module-path branch from a0bedd5 to f4c4148 Compare June 6, 2024 10:27
@sormuras
Copy link
Member

...still cannot reproduce the test failure on my Windows box.

Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved!

marcphilipp and others added 2 commits June 10, 2024 19:59
@marcphilipp marcphilipp merged commit abf5ac3 into main Jun 10, 2024
14 of 15 checks passed
@marcphilipp marcphilipp deleted the marc/3827-fix-console-launcher-version-on-module-path branch June 10, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version reported as null on module path
2 participants