Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not release OSGi HttpService #227

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Conversation

lolodomo
Copy link

@lolodomo lolodomo commented Mar 29, 2024

Related to openhab/openhab-core#4140

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo force-pushed the OSGi_HttpService branch 2 times, most recently from 89ef298 to 6e96b26 Compare March 29, 2024 13:59
@lolodomo
Copy link
Author

Here are the DEBUG logs at startup:

15:04:14.402 [INFO ] [rg.jupnp.OSGiUpnpServiceConfiguration] - OSGiUpnpServiceConfiguration createConfiguration threadPoolSize = 15 true
15:04:14.409 [INFO ] [rg.jupnp.OSGiUpnpServiceConfiguration] - OSGiUpnpServiceConfiguration createConfiguration asyncThreadPoolSize = 30 true
15:04:14.416 [INFO ] [rg.jupnp.OSGiUpnpServiceConfiguration] - OSGiUpnpServiceConfiguration retryAfterSeconds = 600
15:04:14.424 [INFO ] [rg.jupnp.OSGiUpnpServiceConfiguration] - OSGiUpnpServiceConfiguration retryIterations = 5
15:04:14.430 [INFO ] [rg.jupnp.OSGiUpnpServiceConfiguration] - OSGiUpnpServiceConfiguration timeoutSeconds = 10
15:04:14.437 [DEBUG] [rg.jupnp.OSGiUpnpServiceConfiguration] - Creating mainThreadPool
15:04:14.449 [DEBUG] [rg.jupnp.OSGiUpnpServiceConfiguration] - Creating asyncThreadPool
15:04:14.456 [DEBUG] [rg.jupnp.OSGiUpnpServiceConfiguration] - Creating remoteThreadPool
15:04:14.579 [DEBUG] [rg.jupnp.OSGiUpnpServiceConfiguration] - org.openhab.core.config.jupnp.internal.OHUpnpServiceConfiguration@1878cb9 activated

15:04:14.733 [INFO ] [org.jupnp.UpnpServiceImpl            ] - Starting UPnP service...
15:04:14.739 [DEBUG] [org.jupnp.UpnpServiceImpl            ] - Using OSGi HttpService; using configuration: org.openhab.core.config.jupnp.internal.OHUpnpServiceConfiguration
15:04:14.823 [DEBUG] [rg.jupnp.OSGiUpnpServiceConfiguration] - createStreamServer using OSGi HttpService
15:04:14.876 [DEBUG] [rg.jupnp.OSGiUpnpServiceConfiguration] - createStreamServer using OSGi HttpService
15:04:14.904 [DEBUG] [org.jupnp.UpnpServiceImpl            ] - UPnP service started successfully

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating the issue @lolodomo!

@lolodomo lolodomo force-pushed the OSGi_HttpService branch 3 times, most recently from 23ff570 to 4702d3e Compare March 30, 2024 15:10
Move OSGi dependency to HttpService from UpnpServiceImpl to OSGiUpnpServiceConfiguration.

Fix openhab/openhab-core#4140

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
Copy link
Author

lolodomo commented Apr 1, 2024

@wborn : I am preparing a PR in openhab.core to switch to release 3.0.1.

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@wborn wborn merged commit 49486b6 into jupnp:main Apr 1, 2024
4 checks passed
@wborn wborn added this to the 3.0.1 milestone Apr 1, 2024
@lolodomo lolodomo deleted the OSGi_HttpService branch April 1, 2024 11:32
@lolodomo
Copy link
Author

lolodomo commented Apr 1, 2024

@wborn: to you know the process to release a new version ? ;)

@wborn
Copy link
Member

wborn commented Apr 1, 2024

to you know the process to release a new version ? ;)

I know the process but only @kaikreuzer can do it. 😉
Would also be nice when the new release contains #229.

@wborn wborn added the bug label Apr 1, 2024
@kaikreuzer
Copy link
Member

New version is published.

but only @kaikreuzer can do it. 😉

We should change that. Not sure how we get you the rights to push to Maven Central for the org, but according to https://central.sonatype.org/faq/what-happened-to-issues-sonatype-org/#i-used-to-registerudate-my-ossrh-account-at-issuessonatypeorg-what-do-i-do-now it sounds as if I have to send an email to Sonatype. Can you give me your OSSRH id for that?

@wborn
Copy link
Member

wborn commented Apr 4, 2024

Thanks for making the release. 👍

it sounds as if I have to send an email to Sonatype. Can you give me your OSSRH id for that?

I don't have a personal OSSRH account yet. It also seems that OSSRH is considered legacy nowadays because Maven Central has a new publishing mechanism. I do have a personal Maven Central account with a few verified namespaces. So I mailed them if it is required for me to also get a legacy OSSRH account or if the org.jupnp namespace can also be added to my existing Maven Central account.

@wborn
Copy link
Member

wborn commented Apr 4, 2024

I just got this reply from central-support@sonatype.com :

To grant you permissions to org.jupnp, I would need to get a request from someone with publishing access to that namespace.

Accounts on central.sonatype.com can be used to publish on OSSRH, provided they are username/password accounts. You cannot publish a namespace on both systems however, it's one or the other.

My central.sonatype.com account has wborn as username. It's username/password based and not using a social login. Do you also have a central.sonatype.com account?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants