Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43: started to prototype the python side of the interface #54

Closed
wants to merge 7 commits into from

Conversation

sanbales
Copy link
Contributor

@sanbales sanbales commented Feb 21, 2023

NOTICE: Not ready for review

Putting this up as PR to elicit input from @nrbgt and @dfreeman06 .

References

Addresses #43

Code changes

  • Adding a new NodeShape behavior that allows for using a declarative approach to drawing on the canvas (leverages declarative-canvas library)
  • make sure it can be used in 3D as well
  • add declarative-canvas to the ts side and implement the interfaces there

User-facing changes

  • Allows for users to make the nodes look like circles, rectangles, use images, a custom path, or text.

Backwards-incompatible changes

  • None.

@sanbales sanbales linked an issue Feb 21, 2023 that may be closed by this pull request
@github-actions
Copy link

[![lite-badge](https://jupyterlite.rtfd.io/en/latest/_static/badge.svg)](https://ipyforcegraph--54.org.readthedocs.build/en/54/_static/lab/index.html?path=_index.ipynb) :point_left: Try it on ReadTheDocs or Binder :point_right: [![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/undefined/undefined?urlpath=lab/tree/examples/_index.ipynb)

@sanbales sanbales marked this pull request as draft February 21, 2023 20:09
@sanbales sanbales added enhancement New feature or request help wanted Extra attention is needed labels Feb 22, 2023
@sanbales sanbales self-assigned this Feb 22, 2023
@sanbales sanbales closed this Feb 23, 2023
@sanbales sanbales deleted the gh-43-custom-node-shapes branch February 23, 2023 21:47
@sanbales sanbales restored the gh-43-custom-node-shapes branch February 23, 2023 21:47
@sanbales sanbales mentioned this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Permanent node labels
2 participants