Postmortem for 0.3.0 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Try it on |
nrbgt
force-pushed
the
gh-65-postmortem-030
branch
2 times, most recently
from
ea0533e
to
59c73a7
Compare
nrbgt
force-pushed
the
gh-65-postmortem-030
branch
from
59c73a7
to
7c69f59
Compare
sanbales
approved these changes
Mar 16, 2023
nrbgt
force-pushed
the
gh-65-postmortem-030
branch
2 times, most recently
from
4e8724b
to
3f01ecf
Compare
nrbgt
force-pushed
the
gh-65-postmortem-030
branch
from
3f01ecf
to
dcc82b7
Compare
sanbales
approved these changes
Mar 20, 2023
| - [ ] 🐧`source envs/lock/bin/activate` | ||
| - [ ] 🪟 `call envs/lock/Scripts/activate.bat`) | ||
| - [ ] run `doit lock` | ||
| - [ ] commit the new locks |
There was a problem hiding this comment.
should they re-run all the tests after re-locking? asking in case a new dependency breaks something, CI should catch that, and probably not necessary to explicitly call for it...
There was a problem hiding this comment.
yeah, naw: the idea is CI does the heavy lifting after you quickly set everything up. "Works on my machine," is a very real possibility after a resolve, CI gonna find it.
sanbales
reviewed
Mar 20, 2023
This was referenced Mar 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
devbranch workflow #67Code changes
0.3.1yarn.lock.github/locksrelease.mdenv).github/**/*.mdchanges are picked up byprettierhttps://ipyforcegraph--66.org.readthedocs.build/en/66/_static/ipyforcegraph-0.3.1.tar.gzhttps://ipyforcegraph--66.org.readthedocs.build/en/66/_static/ipyforcegraph-0.3.1-py3-none-any.whlREADME.mdxrefnot wrapped in ana__all__frombehaviors/_base.pyso all the classes show updevrelease.mdpull_request_template.mdCONTRIBUTING.mdREADME.mdmainanddevnbqaUser-facing changes
Backwards-incompatible changes