Fix serializers for jupyterlab_widgets 3.0.6
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## References Resolves jupyrdf#60 by adding `curvature` and `line dashes` to `LinkShape`. ## Code changes - [x] add `curvature` to `LinkShape` - [x] add `line_dash` to `LinkShape` - [x] disable this behavior in 3D (it is not supported) - [x] add coercion to `array` for `line_dash` data - [x] update notebooks - [x] fixed a small issue with `node` selection in `Behaviors.ipynb` - [x] update docs - [x] add tests - [x] `str` inputs - [x] `int` inputs - [x] `float` inputs - [x] `Column` inputs - [x] `Nunjucks` inputs - [x] `LinkShape.color` - [x] `LinkShape.curvature` - [x] `LinkShape.line_dash` - [x] `LinkShape.width` - [x] Interaction with selection - [x] need to make sure `LinkSelection` is included before `LinkShape` to show selection styling - [x] `LinkSelection` works but it is not tested in conjunction with `LinkShape` - [x] future work would be to figure out a way to make `default_curvature=None` to leave the link with its non-selected `curvature` ## User-facing changes * Two new properties on `LinkShape`: * `LinkShape.curvature`: * 0.0 produces a straight link (default) * 1.0 circular link (i.e., `radius of curvature` = `0.5 * link length`) * negative numbers mirror the link * `LinkShape.line_dashes`: * Define the line dashes using an array of numbers, [reference](https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/setLineDash) ## Backwards-incompatible changes > No backwards incompatible changes (**knock on wood**)
|
Try it on |
|
do we need to bump our |
#68 is demonstrating it against the newer version, wanted to get a clean run of this against the older versions to see if the relationship is more nuanced. As mentioned, we could bring in more of |
Propose we merge what was included in #62 as it seems to work. The only thing left re: to #62 (AFAIK) was preserving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
jupyterlab_widgets3.0.6 #71Code changes
devjupyterlab-widgets<3.0.6,ipywidgets<8.0.5,ipykernel<6.22in the test matrix0.3.1User-facing changes
ipywidgetsandjupyterlab_widgets(and still work with older ones that pin)Backwards-incompatible changes