-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DodoSource #68
Add DodoSource #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just some small things I ran into
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a couple of small comments, but happy to merge if you are cool with it.
- removes the significance of order in `ForceGraph.behaviors` | ||
- all node, link, and graph behaviors now have a (sensible default) `.rank` trait | ||
which determines the order in which they are applied. | ||
- lower `rank` are applied before higher `rank` | ||
- adds `DodoSource` for interpreting `doit` tasks graphs | ||
- adds `node_preserve_columns`, `link_id_column`, and `link_preserve_columns` | ||
- these allow for keeping values when updating data, such as those created by the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to double check this was still going in this PR...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, it's in here, and the demo shows some improvement in the stability of the render, though the vanilla forces still encourage stuff to move
docs/_static/logo.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't tell the difference between these two. Only bringing it up in case it was an unintentional commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has just been compressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran a doit lab
locally and played with the DodoApp.ipynb
for a while.
Seems to be working well. Only things I've noticed (and these may be PEBCAK or not intended):
- selection from
datagrid
to graph does not seem to work (i.e., selecting a row on the grids, does not highlightnodes
orlinks
on the graph) - sometimes the between particles do not seem to appear for things someone might expect (e.g., from
env
tosetup
)
Tried it on lite
as well but didn't see the Dodo
notebooks in there.
"""Draw a text shape, with an optional background.""" | ||
"""Draw a text shape, with an optional background. | ||
|
||
If the ``text`` trait is (or evaluates to) ``0`` or ``None``, no shape will be drawn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the same happen with height
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would visually hide it, but you'd still pay the canvas price
thanks for the review! 😍
Yep, they don't work in lite because
will look into it. Trying to get fancy with non-blocking stuff. Got some ideas on how that could be improved.
will look into it |
oof, this is general failure, even setting it programmatically doesn't work.
the issue is that we don't update the |
fixed selection on 43202f1 |
Ah, this might due to it actually being a bit more accurate now, as it will only show particles if there is a path of the form:
(Or the reverse) Initially, it kinda lied, as it would follow sibling paths like:
So basically: a lot of the nodes aren't particularly sensitive to other nodes. If there's a concrete example, happy to look into it! |
Yeah, that makes sense. No, I don't think it's worth it to go beyond what you've done. It's working nicely! |
References
Code changes
ipydatagrid
ipytree
ipylab
ipywidgets
andjupyterlab_widgets
DodoSource
file_dep
andtask_dep
linkslinkHandlers
andnodeHandlers
better for facetsRectangle.width
andText.text
)line_dash
to more shapes (via HasStrokeAndFill)jupyterlite-core
andpyodide-kernel
User-facing changes
users of the binder demo will be able to try out the grid against an evolving system
users of the lit demo will see:
Backwards-incompatible changes