Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI quick-setup incompatibility with notebook 5.0 #56

Closed
parente opened this issue Feb 16, 2017 · 0 comments
Closed

CLI quick-setup incompatibility with notebook 5.0 #56

parente opened this issue Feb 16, 2017 · 0 comments
Milestone
0.7.0

Comments

@parente
Copy link
Member

parente commented Feb 16, 2017

The BaseNBExtensionApp class is gone so the check if we're in >=4.2 fails here: https://github.com/jupyter/dashboards/blob/master/jupyter_dashboards/extensionapp.py#L12. Probably need to use notebook.extensions.BaseExtensionApp instead. That or remove the quick-setup convenience step and have people write out the install/enable/disable/uninstall manually.

https://github.com/jupyter/notebook/blob/master/notebook/extensions.py#L52

Ref: jupyter/notebook#2150
@parente parente modified the milestone: 0.7.0 Feb 22, 2017
@parente parente closed this as completed in e997060 Apr 5, 2017
parente added a commit that referenced this issue Apr 5, 2017
@parente
Merge pull request #57 from parente/fix-56-notebook-5.0-compat
28cddd0 
Fix #56: Notebook 5.0 compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
1 participant
@parente