Pluggable deploy as, download as mechanism #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow edits during dev without disturbing the git controlled version (c) Copyright IBM Corp. 2015
(c) Copyright IBM Corp. 2015
(c) Copyright IBM Corp. 2015
Let the bundler decide what to do completely because two calls to finish results in an exception (c) Copyright IBM Corp. 2015
(c) Copyright IBM Corp. 2015
(c) Copyright IBM Corp. 2015
parente
force-pushed
the
deploy-extension
branch
from
8b526ae
to
88fe13a
Compare
(c) Copyright IBM Corp. 2015
parente
changed the title
* BundlerTools available on hander passed to bundler() * Tests for bundler tools w/ test assets * Makefile targets for testing * Makefile var name changes for consistency with other projects (c) Copyright IBM Corp. 2015
* All public methods (each one is potentially useful) * More consistent naming (c) Copyright IBM Corp. 2015
| :param handler: The tornado web handler that serviced the request | ||
| :param absolute_notebook_path: The path of the notebook on disk | ||
| ''' | ||
| self.finish('Hello world!'') |
There was a problem hiding this comment.
Should be called on handler, not self.
|
Reviewed with @parente. This makes sense to me to let other extensions bring in other bundlers. |
(c) Copyright IBM Corp. 2015
|
Merging this in to pave the way for the other initial bundler impls to go in as well. |
parente
added a commit
that referenced
this pull request
Dec 16, 2015
Pluggable deploy as, download as mechanism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #13