Merge pull request #759 from jupyter-incubator/devstein/support-ipyth…

…on-8 Support IPython 8
jupyter-incubator · May 1, 2022 · 691018f · 691018f
2 parents c4b9b99 + 7b71500
commit 691018f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@
 ### Bug Fixes
 
 * Fixed, simplified, and sped up the sparkmagic Docker images for local development and testing
+* Adds support for `ipython>=8`
 
 ## 0.19.2
 

diff --git a/hdijupyterutils/hdijupyterutils/ipythondisplay.py b/hdijupyterutils/hdijupyterutils/ipythondisplay.py
@@ -20,12 +20,12 @@ def stdout_flush(self):
         sys.stdout.flush()
 
     def write(self, msg):
-        self._ipython_shell.write(msg)
+        sys.stdout.write(msg)
         self.stdout_flush()
 
     def writeln(self, msg):
         self.write("{}\n".format(msg))
 
     def send_error(self, error):
-        self._ipython_shell.write_err("{}\n".format(error))
+        sys.stderr.write("{}\n".format(error))
         self.stderr_flush()
diff --git a/hdijupyterutils/setup.py b/hdijupyterutils/setup.py
@@ -56,7 +56,7 @@ def version(path):
         "Programming Language :: Python :: 3.7",
     ],
     install_requires=[
-        "ipython>=4.0.2,<8",
+        "ipython>=5",
         "nose",
         "mock",
         "ipywidgets>5.0.0",

diff --git a/sparkmagic/setup.py b/sparkmagic/setup.py
@@ -82,7 +82,7 @@ def version(path):
     install_requires=[
         "hdijupyterutils>=0.6",
         "autovizwidget>=0.6",
-        "ipython>=4.0.2",
+        "ipython>=5",
         "nose",
         "mock",
         "pandas>=0.17.1",