Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPython 8 #759

Merged
merged 3 commits into from May 1, 2022
Merged

Support IPython 8 #759

merged 3 commits into from May 1, 2022

Conversation

devstein
Copy link
Collaborator

@devstein devstein commented Apr 27, 2022

Closes #747

Description

IPython.core.interactiveshell.InteractiveShell.write and
IPython.core.interactiveshell.InteractiveShell.write_err have been deprecated since IPython 5 and were finally removed in IPython 8. This removes the deprecated method calls. I also bumped the minimum ipython version to 5. I don't see a reason to support 4.

cc @utkarshgupta137

Checklist

  • Wrote a description of my changes above
  • Added a bullet point for my changes to the top of the CHANGELOG.md file
  • Added or modified unit tests to reflect my changes
  • Manually tested with a notebook
  • If adding a feature, there is an example notebook and/or documentation in the README.md file

These methods have been deprecated since Ipython5 ipython/ipython@967e96e
@devstein devstein merged commit 691018f into master May 1, 2022
@devstein devstein deleted the devstein/support-ipython-8 branch May 1, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Sparkmagic errors out with ipython 8.x
1 participant