Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPython 8 #759

Merged
merged 3 commits into from
May 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
### Bug Fixes

* Fixed, simplified, and sped up the sparkmagic Docker images for local development and testing
* Adds support for `ipython>=8`

## 0.19.2

Expand Down
4 changes: 2 additions & 2 deletions hdijupyterutils/hdijupyterutils/ipythondisplay.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ def stdout_flush(self):
sys.stdout.flush()

def write(self, msg):
self._ipython_shell.write(msg)
sys.stdout.write(msg)
self.stdout_flush()

def writeln(self, msg):
self.write("{}\n".format(msg))

def send_error(self, error):
self._ipython_shell.write_err("{}\n".format(error))
sys.stderr.write("{}\n".format(error))
self.stderr_flush()
2 changes: 1 addition & 1 deletion hdijupyterutils/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def version(path):
"Programming Language :: Python :: 3.7",
],
install_requires=[
"ipython>=4.0.2,<8",
"ipython>=5",
"nose",
"mock",
"ipywidgets>5.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sparkmagic/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def version(path):
install_requires=[
"hdijupyterutils>=0.6",
"autovizwidget>=0.6",
"ipython>=4.0.2",
"ipython>=5",
"nose",
"mock",
"pandas>=0.17.1",
Expand Down