Fail eagerly to wait for the idle status if we have reached a "final" status #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -0,0 +1,3 @@ | |||
| class LivyUnexpectedError(Exception): | |||
| """An exception that will be shown if some unexpected error happens on the Livy side.""" | |||
There was a problem hiding this comment.
Can we rename to LivyUnexpectedFinalStatusErrors? This seems too broad.
There was a problem hiding this comment.
My idea was that this exception could be used for other uses besides just an unexpected final status but this is OK too.
|
All sessions include a logs field. Include logs in message If exception is in error. |
|
Please include Closes #66 when addressing a bug. That will close it automatically on merge. |
|
What is the name of the extra field? |
|
Lgtm! Merging |
aggFTW
added a commit
that referenced
this pull request
Dec 19, 2015
Fail eagerly to wait for the idle status if we have reached a "final" status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait_for_status()towait_for_idle()and adjust parameter list appropriately. If we ever need to wait for a status besides idle (seems unlikely?), then this can be refactored back out again.LivyUnexpectedErrorif the Livy session goes into error or dead.