Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test unreachable code, fix style #737

Merged
merged 1 commit into from Dec 31, 2021
Merged

Conversation

krassowski
Copy link
Member

References

Follow up to #736

Code changes

  • use greyscale + stronger opacity for Unnecessary tag
  • fix class name for Unnecessary
  • add test case for Unnecessary using javascript for now

User-facing changes

Screenshot from 2021-12-31 01-28-09

Backwards-incompatible changes

Chores

  • linted
  • tested
  • documented
  • changelog entry

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch jupyter-lsp/jupyterlab-lsp/fix-diagnostics-style

@krassowski krassowski merged commit f08e1dc into master Dec 31, 2021
@krassowski krassowski deleted the fix-diagnostics-style branch December 31, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant