Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use app http settings for status, WebSockets #881

Closed

Conversation

bollwyvl
Copy link
Collaborator

@bollwyvl bollwyvl commented Dec 9, 2022

References

Code changes

  • initialize LanguageServerManager with app.serviceManager.settingsis being used
  • use these settings for doing API requests and WebSockets
  • handle a race condition for very fast settings loading (no http request) for plugins with a PromiseDelegate
  • rev some node versions (not sad about retiring 14 a little early)
  • resolve and deduplicate yarn.lock: get "one true version" of typescript, prettier, webpack
  • use webpack 5 for lsp-ws-connection
  • add sourcemaps (we can take these out, but... would be really nice for downstream debugging)
  • refresh robot tooling

User-facing changes

  • hopefully few visible changes

Backwards-incompatible changes

  • hopefully none: no signatures were changed

Chores

  • linted
  • tested
  • documented
  • changelog entry

@bollwyvl bollwyvl changed the title Use app http settings Use app http settings for status, WebSockets Dec 9, 2022
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Binder 👈 Launch a binder notebook on branch bollwyvl/jupyterlab-lsp/gh-880-use-app-http-settings

@krassowski
Copy link
Member

I will get #869 in to help with CI.

@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Dec 9, 2022 via email

@bollwyvl
Copy link
Collaborator Author

With #869 looking good, i'll rebase on top of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants