Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JupyterLab 4.0 migration #949

Merged
merged 83 commits into from
Aug 26, 2023
Merged

JupyterLab 4.0 migration #949

merged 83 commits into from
Aug 26, 2023

Commits on Jun 18, 2023

  1. WIP JupyterLab 4.0 migration

    @krassowski
    krassowski committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    857b593 View commit details
    Browse the repository at this point in the history

  2. More WIP (hover, rename, signature)

    @krassowski
    krassowski committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    81ca55f View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. More WIP

    @krassowski
    krassowski committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    425df9c View commit details
    Browse the repository at this point in the history

  2. WIP jumpers

    @krassowski
    krassowski committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    12ddee3 View commit details
    Browse the repository at this point in the history

  3. Add diagnostics WIP feature

    @krassowski
    krassowski committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    d299648 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2023

  1. WIP migrate code jumpers keybindings

    @krassowski
    krassowski committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    d2bed30 View commit details
    Browse the repository at this point in the history

  2. Migrate example extractor

    @krassowski
    krassowski committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    1b50ce7 View commit details
    Browse the repository at this point in the history

  3. WIP completion, diagnostics, comment out others

    @krassowski
    krassowski committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    c6fdefc View commit details
    Browse the repository at this point in the history

  4. Remove custom connection manager subclass, various fixes

    @krassowski
    krassowski committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    3298679 View commit details
    Browse the repository at this point in the history

  5. Fix eslint

    @krassowski
    krassowski committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    b541f17 View commit details
    Browse the repository at this point in the history

  6. Update yarn lock after restoring npm-run-all

    @krassowski
    krassowski committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    2972037 View commit details
    Browse the repository at this point in the history

  7. Lint

    @krassowski
    krassowski committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    94cfde9 View commit details
    Browse the repository at this point in the history

  8. Fix up hover

    @krassowski
    krassowski committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    274de85 View commit details
    Browse the repository at this point in the history

  9. Set version range for 4.0

    @krassowski
    krassowski committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    d2e960c View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Remove option no longer supported by yarn

    @krassowski
    krassowski committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    99def20 View commit details
    Browse the repository at this point in the history

  2. Update yarn.lock

    @krassowski
    krassowski committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    cfc00cd View commit details
    Browse the repository at this point in the history

  3. Implement tags, add document length guard, remove type cast 

    (no longer needed with new version of `@codemirror/lint`).
    @krassowski
    krassowski committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    01f95e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Remove commented out code and correct optional tokens use

    @krassowski
    krassowski committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    b13280c View commit details
    Browse the repository at this point in the history

  2. Work-in-progress on porting jump-to

    @krassowski
    krassowski committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    d5779ae View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Update types import after renaming settings (added s)

    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    0775874 View commit details
    Browse the repository at this point in the history

  2. Fix positionFromCoordinates

    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    1fafc45 View commit details
    Browse the repository at this point in the history

  3. Finish first pass on jump-to feature

    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    8c64a96 View commit details
    Browse the repository at this point in the history

  4. Fix position in local jump

    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    57170ff View commit details
    Browse the repository at this point in the history

  5. Update yarn command for yarn 3

    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    79df8d7 View commit details
    Browse the repository at this point in the history

  6. Update caching and versions

    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    4f95e85 View commit details
    Browse the repository at this point in the history

  7. Try with '.yarn/cache'

    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    8fe2d88 View commit details
    Browse the repository at this point in the history

  8. Switch to portal: protocol for metapackage setup to fix immutable 

    install validation on CI. `workspace:` is another good option but
requires some more configuration - portal may be good enough for now.
    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    66aa65c View commit details
    Browse the repository at this point in the history

  9. Switch to workspaces after all cause lerna does not support portals 

    Using `workspace:*` over relative specs as paths are experimental,
and as of today did not work for me in any reasonable way (either
resolution worked but build did not, or both did not depending on
attempt).
    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    17b886c View commit details
    Browse the repository at this point in the history

  10. Revert attempts to switch protocol as these break other things. 

    I will disable immutable installs on CI for now instead.
    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    17423f4 View commit details
    Browse the repository at this point in the history

  11. Disable immutable installs for now

    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    0fbc50d View commit details
    Browse the repository at this point in the history

  12. Update versions

    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    d4c8090 View commit details
    Browse the repository at this point in the history

  13. Update lerna (we need 6.4.0 to fix CI)

    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    5c2ffd6 View commit details
    Browse the repository at this point in the history

  14. lerna 6.6 has similar issue, pinning 6.5; see: 

    lerna/lerna#3622
    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ad4aadb View commit details
    Browse the repository at this point in the history

  15. Drop jest from metapackage complier options

    @krassowski
    krassowski committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    bc723da View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. Port highlights feature, improve hover, WIP syntax highlighting

    @krassowski
    krassowski committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    da7ab8f View commit details
    Browse the repository at this point in the history

  2. Finish syntax highlighting port

    @krassowski
    krassowski committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    78b3e70 View commit details
    Browse the repository at this point in the history

  3. Highlights: remove outdated comments, add micro benchmarking result

    @krassowski
    krassowski committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    cd962d7 View commit details
    Browse the repository at this point in the history

  4. Fix focusing on editor, remove deprecated function

    @krassowski
    krassowski committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    8b0795e View commit details
    Browse the repository at this point in the history

  5. Fix offsets in assembler

    @krassowski
    krassowski committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    674d47e View commit details
    Browse the repository at this point in the history

  6. Fix redundant non-null assertion

    @krassowski
    krassowski committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    f283329 View commit details
    Browse the repository at this point in the history

  7. Fix diagnostics in notebook across cells, allow to enable gutter

    @krassowski
    krassowski committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    15e4984 View commit details
    Browse the repository at this point in the history

  8. Fix floating promises

    @krassowski
    krassowski committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    837af5e View commit details
    Browse the repository at this point in the history

  9. Port highlighting of code and current parameter in signature

    @krassowski
    krassowski committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    7295761 View commit details
    Browse the repository at this point in the history

  10. Finish porting rename, expose diagnostics database via token

    @krassowski
    krassowski committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    cb19dec View commit details
    Browse the repository at this point in the history

  11. Rename file with ContextAssembler to reflect its new content

    @krassowski
    krassowski committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    7322569 View commit details
    Browse the repository at this point in the history

  12. Harmonise completion items (override default providers)

    @krassowski
    krassowski committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    790d382 View commit details
    Browse the repository at this point in the history

  13. Restore LSP completions transformation, 

    and add stub for continuous typing
    @krassowski
    krassowski committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    7db712c View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2023

  1. Add new yarnrc, try skipLibCheck

    @krassowski
    krassowski committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    5482fb7 View commit details
    Browse the repository at this point in the history

  2. Remove yarn2 options

    @krassowski
    krassowski committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    9353e34 View commit details
    Browse the repository at this point in the history

  3. Remove interactive upgrade plugin

    @krassowski
    krassowski committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    1523526 View commit details
    Browse the repository at this point in the history

  4. Try again with workspaces, restores 7b886c84c4d62397a2aac14ebe69a95f2… 

    …901d84

It could work this time because lerna version was upgraded in the
meantime, fixing some of the issues.
    @krassowski
    krassowski committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    8543d64 View commit details
    Browse the repository at this point in the history

  5. Re-enable immutable installs (default)

    @krassowski
    krassowski committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    7065abb View commit details
    Browse the repository at this point in the history

  6. Fix tests setup: 

    - remove `jest-github-actions-reporter` in favour of `github-actions`
  reporter shipping with jest 28+
- pin resolution of jest version to enable the above
- fix jest config to account for changes upstream and new packages
- fix babel config to account for renamed files upstream
    @krassowski
    krassowski committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    a679f0e View commit details
    Browse the repository at this point in the history

  7. Update version specifiers for JupyterLab and Python

    @krassowski
    krassowski committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    a08845c View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Upgrade to lab 4.0.3 removing which allows to remove most ts-ignores 

    Also de-duplicate lock file
    @krassowski
    krassowski committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    17039bf View commit details
    Browse the repository at this point in the history

  2. Silence remaining @ts-ignores in linting output for now

    @krassowski
    krassowski committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    80a1704 View commit details
    Browse the repository at this point in the history

  3. Fix statusbar status and popup: 

    - determine adapter using current shell widget
- pass `hasDynamicSize` to show popup to get it to display properly
- move `shortMessageByStatus` to fix translations
    @krassowski
    krassowski committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    afef4bf View commit details
    Browse the repository at this point in the history

  4. Fix version integrity

    @krassowski
    krassowski committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    7caea23 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. Fix signature highlight when parameter is not given

    @krassowski
    krassowski committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    1f42235 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Restore tests for edits and renaming

    @krassowski
    krassowski committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    4167c48 View commit details
    Browse the repository at this point in the history

  2. Port diagnostics test, delay promise evaluation by frame

    @krassowski
    krassowski committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a0c67cd View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Finalise porting unit tests

    @krassowski
    krassowski committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    809ad06 View commit details
    Browse the repository at this point in the history

  2. Stop testing serverextension since notebook v7 using jupyter-server… 

    … is now out
    @krassowski
    krassowski committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    a6b47ce View commit details
    Browse the repository at this point in the history

  3. Update config for examples

    @krassowski
    krassowski committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    2fe9d88 View commit details
    Browse the repository at this point in the history

  4. Test smoke with node 18

    @krassowski
    krassowski committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    228311a View commit details
    Browse the repository at this point in the history

  5. Do not bail on test failure in a task

    @krassowski
    krassowski committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    f749246 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Partially fix settings rendering

    @krassowski
    krassowski committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    4a37d01 View commit details
    Browse the repository at this point in the history

  2. Pin selenium

    @krassowski
    krassowski committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    5adf6b8 View commit details
    Browse the repository at this point in the history

  3. Restore support for theming diagnostics underlines (only colour)

    @krassowski
    krassowski committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    cb75215 View commit details
    Browse the repository at this point in the history

  4. Start porting acceptance tests

    @krassowski
    krassowski committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    4ce1feb View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Bump required JupyterLab version to 4.0.5

    @krassowski
    krassowski committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    85cc0ca View commit details
    Browse the repository at this point in the history

  2. Update script bumping versions

    @krassowski
    krassowski committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    827b78e View commit details
    Browse the repository at this point in the history

  3. Restore auto-completion, not working yet due to missing context upstream

    @krassowski
    krassowski committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    29edf58 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Update completer model settings as needed, and advertise 

    completer provider as unavailable if the plugin is soft-disabled
    @krassowski
    krassowski committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    92ba7d8 View commit details
    Browse the repository at this point in the history

  2. Bump version to 5.0.0-alpha.0

    @krassowski
    krassowski committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    e7c5f72 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. Completer fixes, re-implement disable option

    @krassowski
    krassowski committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    e1697da View commit details
    Browse the repository at this point in the history

  2. Rename branch

    @krassowski
    krassowski committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    cc432c9 View commit details
    Browse the repository at this point in the history

  3. Ensure marks/diagnostics do not exceed editor length 

    Essential to prevent CM6 error during edits:
"Position X is out of range for changeset of length Y"
which happens when the virtual document text/line is longer than the editor
text/line, usually because of cell/line magic overrides
    @krassowski
    krassowski committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    3013503 View commit details
    Browse the repository at this point in the history

  4. Add missing await before accessing rename settings

    @krassowski
    krassowski committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    f3f4cf5 View commit details
    Browse the repository at this point in the history

  5. Fix infinite loop for standalone docs and logging after tests

    @krassowski
    krassowski committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    5fc93f0 View commit details
    Browse the repository at this point in the history

  6. Fix version spec in smoke test

    @krassowski
    krassowski committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    d1873ac View commit details
    Browse the repository at this point in the history

  7. Correct offset guard and add more guards for diagnostics

    @krassowski
    krassowski committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    27d11ec View commit details
    Browse the repository at this point in the history

  8. More work on restoring acceptance tests

    @krassowski
    krassowski committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    b0e8cab View commit details
    Browse the repository at this point in the history