Adds extension point for custom environment UI #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
for more information, see https://pre-commit.ci
dlqqq
reviewed
Sep 20, 2022
This was referenced Sep 20, 2022
Closed
awaisabir
reviewed
Sep 20, 2022
3coins
requested changes
Sep 20, 2022
* collapsible panel and styling * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Move optional attributes after required ones * use jupyterlab css var for bold font * rename expandedByDefault? prop to expanded? * Update src/components/collapsible-panel.tsx Co-authored-by: Piyush Jain <piyushjain@duck.com> * propagete function name change * make content conditionaly-visible instead of creating/destroying it on CollapsiblePanel open/close * render icons directly without ToolbarButtonComponent * Fix icon onClick * add padding on icon as before * fix content rendering * use font weight variable on title too * rename summary into header * simplify divs and css classes * simplify css even further * use h2 instead of div, remove associated css styling * remove handleChange function * remove inremental inline padding on icon * remove top expanded class variant, rename classes to follow .jp-jobs-<Component> convention * move CollapsiblePanel css into separate file * restrict title to string only * add optional children props * render props.children as content * use children directly without converting them to array * remove onClick console.log Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Piyush Jain <piyushjain@duck.com>
* Remove tab bar from notebook job panel. * Change overflow-y on job panel to auto. * Minor updates to empty state text. * Simpify card text. * Use MD Cyan 700 for icons. * Size utility. * Box component. * Adding css variables. * Stack component. * Heading component. * Cluster component. * Updating UI based on new components. * Ad button component. * Use button component. * Minor update to form widths. * Update CSS classes to avoid global conficts. * Adding MUI. * Add JupyterLab->MUI theme adapter. * Update theme provider. * Test basic MUI components. * Working theme adaptation. * More explorations with MUI. * Refactoring models. * Update import. * fix MUI build * set builder to ^3.4.7 * update yarn lock * fix notebook jobs command Co-authored-by: Brian E. Granger <brgrange@amazon.com>
Reinstates functionality of the create job form with MUI components
for more information, see https://pre-commit.ci
3coins
reviewed
Sep 23, 2022
| export type EnvironmentParameterValue = string | number | boolean | ||
|
|
||
| export interface IAdvancedOptionsProps { | ||
| mode: JobsView |
There was a problem hiding this comment.
Are we offering an extension point for "ListJobs"?
|
|
||
| export interface IAdvancedOptionsProps { | ||
| mode: JobsView | ||
| model: ICreateJobModel |
There was a problem hiding this comment.
This is likely going to be support in addition to ICreateJobModel, an analogous to the IJobDetailModel with all properties from the IDescribeJob.
|
Discussed my comments offline with the team, and iterating on this in another PR is okay as this will need changes at other places as well. |
3coins
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extension point based on the sample extension point repo.
In the image below, the component displays an informative message.