Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added compute types #33

Merged
merged 4 commits into from
Sep 23, 2022
Merged

Added compute types #33

merged 4 commits into from
Sep 23, 2022

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Sep 22, 2022

  • Added optional compute_types in the RuntimeEnvironment
  • Implemented idempotency_token in create_job api
  • Removed default echoing of sql queries in server log output

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch 3coins/jupyter-scheduler/add-compute-types

@3coins 3coins self-assigned this Sep 22, 2022
dlqqq
dlqqq requested changes Sep 23, 2022
View reviewed changes
jupyter_scheduler/models.py Outdated Show resolved Hide resolved
jupyter_scheduler/scheduler.py Outdated Show resolved Hide resolved
@3coins 3coins requested a review from dlqqq September 23, 2022 00:59
@dlqqq
Copy link
Collaborator

dlqqq commented Sep 23, 2022

@3coins Thank you! Great work.

@3coins 3coins merged commit 92fcadd into jupyter-server:main Sep 23, 2022
This was referenced Sep 23, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq approved these changes

@JasonWeill JasonWeill Awaiting requested review from JasonWeill

Assignees

@3coins 3coins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@3coins @dlqqq