Update to SQLAlchemy 2.x #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-i
added
dependencies
srdas
reviewed
May 21, 2024
JasonWeill
approved these changes
May 21, 2024
|
Thank you @JasonWeill, @srdas. |
JasonWeill
reviewed
May 22, 2024
JasonWeill
approved these changes
May 22, 2024
nsingl00
pushed a commit
to nsingl00/jupyter-scheduler
that referenced
this pull request
Jun 28, 2024
* update sqlalchemy to 2.x * Add SQLAlchemy 2.x requirement warning to README and readthedocs * change JupyterLab 3 "will reach" to "reached" * Remove "anywhere on earth" as it's not a relevant information anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jupyter Scheduler uses subset of SQLAlchemy functionality supported in both SQLAlchemy 1.x and 2.x.
Updating to SQLAlchemy 2.x would allow people who want to use Jupyter Scheduler and other packages that depend on SQLAlchemy 2.x in the same environment (for example, pandas) to do so.
For reference: SQLAlchemy 2.0 - Major Migration Guide .
Fixes #478.
Will also fix a SQLAlchemy 1.x depreciation warning failing CI in #520: https://github.com/jupyter-server/jupyter-scheduler/actions/runs/9179340732/job/25241262049?pr=520#step:6:463