Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use importlib_resources to read schema.json #138

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 8, 2021

This should help fix an issue noticed when trying to release the releaser.

Example run: https://github.com/jtpio/jupyter_releaser/runs/3542239326

@jtpio jtpio added the bug Something isn't working label Sep 8, 2021
@jtpio jtpio added this to the 0.6 milestone Sep 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #138 (78be2b7) into master (a5be6ea) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   85.50%   85.50%           
=======================================
  Files          17       17           
  Lines        2104     2104           
  Branches      253      253           
=======================================
  Hits         1799     1799           
  Misses        213      213           
  Partials       92       92           
Impacted Files Coverage Δ
jupyter_releaser/util.py 69.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5be6ea...78be2b7. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 5af9ea7 into jupyter-server:master Sep 8, 2021
@jtpio jtpio deleted the importlib branch September 8, 2021 08:56
This was referenced Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants