Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #161

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Cleanup #161

merged 1 commit into from
Sep 15, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 15, 2021

  • Fix handling of PYPI_TOKEN_MAP by moving it to a utility function and add test
  • Fix typos in since_last_stable input handling
  • Take advantage of tbump release to remove pin on tomlkit

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #161 (aabc3e5) into master (1c4f9a2) will increase coverage by 0.48%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   84.99%   85.48%   +0.48%     
==========================================
  Files          17       17              
  Lines        2153     2163      +10     
  Branches      260      263       +3     
==========================================
+ Hits         1830     1849      +19     
+ Misses        232      221      -11     
- Partials       91       93       +2     
Impacted Files Coverage Δ
jupyter_releaser/actions/publish_release.py 0.00% <0.00%> (ø)
jupyter_releaser/python.py 87.50% <75.00%> (-4.17%) ⬇️
jupyter_releaser/tests/test_cli.py 98.96% <75.00%> (-0.21%) ⬇️
jupyter_releaser/cli.py 90.80% <100.00%> (+0.03%) ⬆️
jupyter_releaser/lib.py 84.19% <100.00%> (+0.21%) ⬆️
jupyter_releaser/npm.py 79.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4f9a2...aabc3e5. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 98d6e21 into jupyter-server:master Sep 15, 2021
@jtpio jtpio deleted the fix-get-repo branch September 15, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants