Skip to content

Commit

Permalink
Fix to remove potential memory leak on Jupyter Server ZMQChannelHandl…
Browse files Browse the repository at this point in the history
…er code (#682)

Co-authored-by: Steven Silvester <steven.silvester@ieee.org>
  • Loading branch information
Vishwajeet0510 and blink1073 committed Jan 31, 2022
1 parent 87ab9bb commit 65e990e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion jupyter_server/services/kernels/handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,10 @@ async def _register_session(self):
if stale_handler:
self.log.warning("Replacing stale connection: %s", self.session_key)
await stale_handler.close()
self._open_sessions[self.session_key] = self
if (
self.kernel_id in self.kernel_manager
): # only update open sessions if kernel is actively managed
self._open_sessions[self.session_key] = self

def open(self, kernel_id):
super(ZMQChannelsHandler, self).open()
Expand Down

0 comments on commit 65e990e

Please sign in to comment.