Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to remove potential memory leak on Jupyter Server ZMQChannelHandler code #682

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

Vishwajeet0510
Copy link
Contributor

This PR is in reference with PR #6251. Since similar issue is observed on Jupyter Server side as well, creating this PR to resolve the issue here.

@kevin-bates and @blink1073 please review the PR and do the needful. Thanks for all the help :)

@welcome
Copy link

welcome bot commented Jan 31, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #682 (9b4f3c7) into main (87ab9bb) will increase coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
+ Coverage   77.80%   77.87%   +0.06%     
==========================================
  Files         110      110              
  Lines       10464    10465       +1     
  Branches     1404     1405       +1     
==========================================
+ Hits         8142     8150       +8     
+ Misses       1930     1921       -9     
- Partials      392      394       +2     
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 61.11% <50.00%> (-0.15%) ⬇️
jupyter_server/tests/services/kernels/test_api.py 96.52% <0.00%> (+1.38%) ⬆️
jupyter_server/services/kernels/kernelmanager.py 82.53% <0.00%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ab9bb...9b4f3c7. Read the comment docs.

@blink1073 blink1073 added the bug label Jan 31, 2022
Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073
Copy link
Collaborator

Running script "['pre-commit run --all-files']" on behalf of "blink1073"

@blink1073 blink1073 merged commit 65e990e into jupyter-server:main Jan 31, 2022
@welcome
Copy link

welcome bot commented Jan 31, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@kevin-bates
Copy link
Member

Thank you @Vishwajeet0510 for your contribution and @blink1073 for handling this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants