Optimize hidden checks #1226
Merged
Optimize hidden checks #1226
+171
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boolean check will always be quicker than stat calls, so let's make sure we check that first. Also adds regressions to make sure we don't call `is_hidden` without needing to in the future :)
Convert one needed one into xfail.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1226 +/- ##
==========================================
- Coverage 80.44% 80.40% -0.04%
==========================================
Files 68 68
Lines 8253 8253
Branches 1603 1603
==========================================
- Hits 6639 6636 -3
- Misses 1191 1193 +2
- Partials 423 424 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kevin-bates
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
Nice catch on the optimization! These changes look good - Making Windows Great Again. 😄
(Build (lint) failure is fixed in #1227.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1224. Also adds regression tests, and enables some tests that were skipped on Windows, but did not need to? Maybe they were just passing locally for me?