Replace secure_write, is_hidden, exists with jupyter_core's #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2021
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
…r#382) * distinguish between heartbeat and websocket connection * Bump to 0.19.8
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
…_write Replace secure_write, is_hidden, exists with jupyter_core's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a time when we found many file-system oriented methods replicated in the ecosystem. Since then, many have found homes in
jupyter_core. This PR removes the duplicated implementations and uses those defined in jupyter_core.Resolves #381