Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on pywin32 #514

Merged
merged 1 commit into from
May 9, 2021

Conversation

kevin-bates
Copy link
Member

This dependency should have been dropped as part of the work for #382.

Resolves #281

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #514 (d9272f2) into master (627898f) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
+ Coverage   77.06%   77.14%   +0.08%     
==========================================
  Files         107      107              
  Lines        9495     9495              
  Branches     1027     1027              
==========================================
+ Hits         7317     7325       +8     
+ Misses       1808     1803       -5     
+ Partials      370      367       -3     
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 62.96% <0.00%> (+1.58%) ⬆️
jupyter_server/tests/services/kernels/test_api.py 99.01% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 627898f...d9272f2. Read the comment docs.

@SylvainCorlay SylvainCorlay merged commit 0c63b2e into jupyter-server:master May 9, 2021
@SylvainCorlay
Copy link
Contributor

This is great news. Happy to see this dropped. We should be careful about removing it in the conda recipe when it is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is pywin32 actually used?
3 participants