only use deprecated notebook_dir config if root_dir is not set #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if an existing jupyter_notebook_config file sets notebook_dir, this would override explicit setting of root_dir, as the deprecated value was used even when the new value was also set
Zsailer
approved these changes
Feb 3, 2021
omazapa
added a commit
to omazapa/jupyter-extensions
that referenced
this pull request
Oct 26, 2021
…nager Running locally the root_dir is not set on https://github.com/swan-cern/jupyter-extensions/blob/master/SwanContents/swancontents/filemanager/swanfilemanager.py#L49 but in swan-spare it is set, because at the moment it is not using jupyter_server. to run it locally I found the solution with jupyterlab/jupyterlab#9633 jupyter-server/jupyter_server#400 passing the parameter --NotebookApp.notebook_dir=/path/to/home to jupyterlab
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
…logs with regex; add extra metrics (jupyter-server#400) * simplify the Hubble telemtry design * extend log_request with hubble * more hubble updates * more hubble updates * only set instance of nbservice client in the main app * clean up singleton handling in tests * better typing in base handler * move all huble specific logic into its own submodule * add metrics and prefix metrics with jlab * Bump to 0.21.0
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
only use deprecated notebook_dir config if root_dir is not set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if an existing jupyter_notebook_config file sets notebook_dir, this would override explicit setting of root_dir, as the deprecated value was used even when the new value was also set.
To simulate, you can try: