Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit deprecation warning on old name #411

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

fcollonval
Copy link
Member

Add a deprecation warning on load_jupyter_server_extension

@codecov-io
Copy link

codecov-io commented Feb 11, 2021

Codecov Report

Merging #411 (04f7bb1) into master (3220f4f) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #411   +/-   ##
=======================================
  Coverage   69.90%   69.91%           
=======================================
  Files          57       57           
  Lines        6320     6322    +2     
  Branches      847      847           
=======================================
+ Hits         4418     4420    +2     
- Misses       1599     1600    +1     
+ Partials      303      302    -1     
Impacted Files Coverage Δ
jupyter_server/extension/utils.py 67.56% <50.00%> (-1.01%) ⬇️
jupyter_server/services/kernels/handlers.py 58.51% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3220f4f...04f7bb1. Read the comment docs.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you.

@Zsailer Zsailer merged commit fbe02ae into jupyter-server:master Feb 18, 2021
@fcollonval fcollonval deleted the patch-3 branch February 19, 2021 06:41
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Emit deprecation warning on old name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants