Remove notebook templates and add basic server templates. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This raises an interesting point on what to do with templates+handlers for terminals, nbconvert, the editor, etc. Each of these "extensions" reference templates, js, and css that are client application specific... |
Zsailer
changed the title
|
@blink1073 and @SylvainCorlay any objection to me merging this? |
|
Thanks, Steve! |
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
* add basic tests for traits * fix traits to load dynamically * initial proviser tests * add initial provisioner tests * add missing undefined trait * more provisioner tests * working provisioner tests * add coverage to tests * address coverage gaps * add basic app tests * more app tests and kernelspec tests * refactor main app class to instantiate the NotebookServiceClient * minor reformatting fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #52 and #16.
MainHandlerto handle requests that hit the default URL.These templates are essentially just place holders. Extensions should provide their own templates.