Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default URL when launching jupyter server puts you in infinite loop #52

Closed
yuvipanda opened this issue Jun 4, 2019 · 12 comments
Closed

Comments

@yuvipanda
Copy link
Contributor

  1. Install jupyter_server
  2. Run jupyter server
  3. It opens a URL that's /?token=XXX in browser
  4. This URL infinitely redirects to itself, never shows anything

If you manually have it open something like /voila?token=XXX it works fine. Default behavior should be better.

@afshin
Copy link
Contributor

afshin commented Jun 4, 2019

Does this happen only in Firefox?

@yuvipanda
Copy link
Contributor Author

@afshin chrome and firefox

@afshin
Copy link
Contributor

afshin commented Jun 4, 2019

Cheers!

@afshin
Copy link
Contributor

afshin commented Jun 4, 2019

(That is to say, I have no insight.)

@rolweber
Copy link
Contributor

rolweber commented Jun 4, 2019

Default behavior should be to not open a browser :-) #51

@yuvipanda
Copy link
Contributor Author

@rolweber right, I agree :) However, it does go into an infinite loop even if I specify --ServerApp.open_browser=False, and copy paste the URL manually.

@rolweber
Copy link
Contributor

rolweber commented Jun 4, 2019

We need to come up with a suitable message for the welcome page.

  • You're looking at the tail end of this headless server.

  • Please move on, there's nothing to see here.

  • Welcome! Please go away.

  • Only robots allowed beyond this point.

@SylvainCorlay
Copy link
Contributor

It would make sense to have a tornado template for the a default page (like we have 404.html and 500.html), and have the redirection point to it by default.

  • Someone launching jupyter server would typically end up at this URL unless they specified something else.
  • Someone making explicit use of some ExtensionApp (after @Zsailer's PR is merged) will typically be redirected to the default URL.

@Zsailer
Copy link
Member

Zsailer commented Jun 4, 2019

A default page for the server makes the most sense to me.

We should also remove all the notebook templates in this repo.

@SylvainCorlay
Copy link
Contributor

SylvainCorlay commented Jun 4, 2019

We should also remove all the notebook templates in this repo.

+1

@Zsailer
Copy link
Member

Zsailer commented Jun 4, 2019

Solved in #54

@Zsailer
Copy link
Member

Zsailer commented Jun 6, 2019

I'm going to close this for now since we added a default landing page in #54. Feel free to re-open if this doesn't fix things for you.

@Zsailer Zsailer closed this as completed Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants