Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to remove potential memory leak on Jupyter Server ZMQChannelHandler code #682

Merged
merged 2 commits into from
Jan 31, 2022
Merged

Fix to remove potential memory leak on Jupyter Server ZMQChannelHandler code #682

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03aef7d
Fix to add session only after kernel validation
Vishwajeet0510 Jan 31, 2022
9b4f3c7
lint
blink1073 Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion jupyter_server/services/kernels/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,10 @@ async def _register_session(self):
if stale_handler:
self.log.warning("Replacing stale connection: %s", self.session_key)
await stale_handler.close()
self._open_sessions[self.session_key] = self
if (
self.kernel_id in self.kernel_manager
): # only update open sessions if kernel is actively managed
self._open_sessions[self.session_key] = self

def open(self, kernel_id):
super(ZMQChannelsHandler, self).open()
Expand Down