CanvasView: Make the canvas the main element #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the extra div container, and it means users can now apply the
Layout
property on the Canvas itself instead of the extra container.This means that when the user does:
the canvas will have a "responsive" behavior that respects the available space AND the canvas size ratio.
When doing:
which is the default, the canvas will respect its
width
andheight
properties.And when doing:
the canvas will take 100x100 pixels on the screen, but will actually contain an image of size 200x200.
This should fix #110 and Kitware/ipyvtklink#2, which should both use the first approach.