fix: get it working with jupyter lab #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty painful experience, the first issue was exporting two plugins this way is not supported in jupyter lab. You need to have a default export with a plugin, or a list of.
The second issue has to do with modules, what I think was going on is this:
The handsontable module, when loaded via requirejs is a amd/commonjs module, it will give you the Handsontable object, not a module with a .default or the Handsontable property.
Basically, it's export value is the Handsontable object.
We created handsontable.ts, and exported it using default, which means that it was using handsontable.default.renderers.registerRenderer.
However, when used from jupyter lab, it was using the real handsontable module, not our handsontable.ts, which means it cannot find .default, since that's an es6 module thing, not the commonjs/amd that appearently was being used in bundling.
Short story, of all options, this seems to do the trick!