New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the version validation checks. #1219

Merged
merged 6 commits into from Mar 22, 2017

Conversation

Projects
None yet
1 participant
@jasongrout
Member

jasongrout commented Mar 21, 2017

We rely on the packaging system and users to ensure that installed packages speak compatible protocols. We encourage package authors to very clearly indicate which widget protocol version the package understands.

Fixes #1211

Delete the version validation checks.
We rely on the packaging system and users to ensure that installed packages speak compatible protocols. We encourage package authors to very clearly indicate which widget protocol version the package understands.
@jasongrout

This comment has been minimized.

Member

jasongrout commented Mar 21, 2017

CC @SylvainCorlay - I think it's better to delete the error-prone version comm target and validation checks, and either rely on the users/packager maintainers to make sure the packages understand the same protocol, or implement a version protocol field in all messages.

@jasongrout

This comment has been minimized.

Member

jasongrout commented Mar 21, 2017

I'm going to leave this open a day for comments from @SylvainCorlay or others.

@jasongrout jasongrout merged commit c5b88cd into jupyter-widgets:master Mar 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasongrout jasongrout modified the milestone: 7.0 Apr 11, 2017

@jasongrout jasongrout referenced this pull request Apr 18, 2017

Closed

Update Changelog #1279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment