Delete the version validation checks. #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rely on the packaging system and users to ensure that installed packages speak compatible protocols. We encourage package authors to very clearly indicate which widget protocol version the package understands.
|
CC @SylvainCorlay - I think it's better to delete the error-prone version comm target and validation checks, and either rely on the users/packager maintainers to make sure the packages understand the same protocol, or implement a version protocol field in all messages. |
|
I'm going to leave this open a day for comments from @SylvainCorlay or others. |
Closed
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rely on the packaging system and users to ensure that installed packages speak compatible protocols. We encourage package authors to very clearly indicate which widget protocol version the package understands.
Fixes #1211