-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use numbers abstract base class #236
Use numbers abstract base class #236
Conversation
Looks like the tests themselves are failing at a lower level, in the widgets themselves. We use traitlets to strictly type min and max to |
Can you please tell me how to run the testsuite? I have no idea... |
I spoke too quickly. How to run the tests is in |
Why do you think that? I tested the |
Another way is to peak at how our CI (Travis) does it, defined in .travis.yml in the repo root.
Awesome, glad it's working. It was an erroneous conclusion on my part after a quick look at the test output. |
Use numbers abstract base class
Be compliant with PEP 3141: replace code like
isinstance(foo, (int, float))
byisinstance(foo, numbers.Real)
. This is in particular needed for better SageMath support.