Change css variable names to match Lab #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me! |
|
Thanks! I am really happy about this. This is an appropriate change for ipywidgets 8.0. |
|
Should this be backported to the 7.x branch? |
|
I think it should. This change was in JupyterLab from a long time ago, so it doesn't work in jlab 1, so I think it counts as a bugfix. |
jasongrout
pushed a commit
to jasongrout/ipywidgets
that referenced
this pull request
Mar 2, 2020
Change css variable names to match Lab
Merged
jasongrout
added a commit
that referenced
this pull request
Mar 2, 2020
lock
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #2062 and jupyterlab/jupyterlab#7861.
Lab renamed the css variable for inverse font colors here, which causes styled buttons (e.g.
button_style='danger') in ipywidgets to have the wrong font color (black instead of white) in Lab and Voila. As mentioned in those two issues, documentation and code comments suggest white is the right color.There are possible downstream effects but most of the search results look like snapshots and forks.