New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: fix return key submission of IntText widgets #2975
Bugfix: fix return key submission of IntText widgets #2975
Conversation
7ba1859
to
9151db7
Compare
This is another approach to fixing jupyter-widgets#2959
@meeseeksdev please backport to 7.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
In handleKeyUp there is still this: Is that a problem? value = value.replace(/[e,.\s]/g, ''); |
I think that is fine. It is just stripping out whitespace from the value, not blocking the keystroke. |
Backport #2975 to 7.x: fix return key submission of IntText widgets
Fixes #2959