Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fix return key submission of IntText widgets #2975

Merged
merged 2 commits into from Feb 19, 2022

Conversation

agoose77
Copy link
Contributor

Fixes #2959

@jasongrout jasongrout merged commit a177ce7 into jupyter-widgets:master Feb 19, 2022
@jasongrout
Copy link
Member

@meeseeksdev please backport to 7.x

@lumberbot-app
Copy link

lumberbot-app bot commented Feb 19, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -m1 a177ce778da84f7ff2b8921882d688ff40124d3c
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #2975: Bugfix: fix return key submission of IntText widgets'
  1. Push to a named branch:
git push YOURFORK 7.x:auto-backport-of-pr-2975-on-7.x
  1. Create a PR against branch 7.x, I would have named this PR:

"Backport PR #2975 on branch 7.x (Bugfix: fix return key submission of IntText widgets)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@vidartf
Copy link
Member

vidartf commented Feb 22, 2022

In handleKeyUp there is still this: Is that a problem?

    value = value.replace(/[e,.\s]/g, '');

@jasongrout
Copy link
Member

In handleKeyUp there is still this: Is that a problem?

I think that is fine. It is just stripping out whitespace from the value, not blocking the keystroke.

vidartf added a commit that referenced this pull request Feb 28, 2022
Backport #2975 to 7.x: fix return key submission of IntText widgets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BoundedIntText: Pressing ENTER should trigger change event
3 participants