Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more overview info on docs front page #3488

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

jasongrout
Copy link
Member

This is probably still a bit wordy, but it's nice to have some high-level context on the front page.

Also I deleted the developer_docs page which seemed largely empty.

This is probably still a bit wordy, but it's nice to have some high-level context on the front page.

Also I deleted the developer_docs page which seemed largely empty.
@jasongrout jasongrout added this to the 8.0 milestone Jun 12, 2022
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch jasongrout/ipywidgets/introdocs

Copy link
Member

@ibdafna ibdafna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasongrout jasongrout merged commit 1063621 into jupyter-widgets:master Jun 13, 2022
@jasongrout
Copy link
Member Author

Awesome, thanks for the review. We can keep iterating to make the docs more approachable.

@jasongrout
Copy link
Member Author

@meeseeksdev please backport to 7.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 13, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 106362178c1e2a84e38ecd6d6d3b43f923c1c508
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #3488: Add more overview info on docs front page'
  1. Push to a named branch:
git push YOURFORK 7.x:auto-backport-of-pr-3488-on-7.x
  1. Create a PR against branch 7.x, I would have named this PR:

"Backport PR #3488 on branch 7.x (Add more overview info on docs front page)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

This was referenced Jun 13, 2022
jasongrout added a commit to jasongrout/ipywidgets that referenced this pull request Jun 22, 2022
Add more overview info on docs front page

(cherry picked from commit 1063621)
jasongrout added a commit that referenced this pull request Jun 22, 2022
Backport PR #3488 on branch 7.x (Add more overview info on docs front page)
@jasongrout jasongrout modified the milestones: 8.0, 7.7.1 Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants