Narrow deserialize and improve strictness #3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be more explicit about the fact that we don't know the output of deserialized output
This also makes it explicit which exceptions from full strictness that we rely on:
- noImplicitThis: Mostly in backbone patch
- strictPropertyInitialization: a bunch of properties initialized during backbone init calls is not covered correctly for this strict check
- strictFunctionTypes: The ISerializer interface makes all the arguments optional to allow simpler definitions (`deserializer: (value: any): unknown => { ... }`). However, this does cause `unpack_models` to be typed
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the easier to approve changes from #3570:
This increases the typescript strictness, and makes the exceptions that we need explicit (this will also opt us in to any future TS strictness checks by default). In addition to that, the following changes were made: