Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datetime widget fixes #3581

Merged
merged 8 commits into from
Sep 2, 2022
Merged

Datetime widget fixes #3581

merged 8 commits into from
Sep 2, 2022

Commits on Sep 1, 2022

  1. Export the NaiveDatetimePicker as well 

    This was missed in previous PR.
    @vidartf
    vidartf committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    2b2cc27 View commit details
    Browse the repository at this point in the history

  2. Accept None for Date[time]Picker widgets 

    While hard to reproduce, there has been some reports about this being an issue, so we make an explicit check to cover this case.
    @vidartf
    vidartf committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    562f6a2 View commit details
    Browse the repository at this point in the history

  3. datetime test lint 

    Clean up some test and variable names and extract some common value for readability
    @vidartf
    vidartf committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    405c62a View commit details
    Browse the repository at this point in the history

  4. Add a regression test for time and datetime cross validation 

    Also fixes the none check in time validation
    @vidartf
    vidartf committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    36add2b View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Add NaiveDatetimePicker to docs

    @vidartf
    vidartf committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    09ecd98 View commit details
    Browse the repository at this point in the history

  2. Further tweaks to NaiveDatetimePicker docs

    @vidartf
    vidartf committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    7085fd9 View commit details
    Browse the repository at this point in the history

  3. Fix porting error

    @vidartf
    vidartf committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    9618f39 View commit details
    Browse the repository at this point in the history

  4. Fix docs typo

    @jasongrout
    jasongrout committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    04ecd58 View commit details
    Browse the repository at this point in the history