Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notifications changing our visual tests #3694

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

jasongrout
Copy link
Member

@martinRenou points out that upgrading Galata might fix the notifications that are now photobombing our screenshots.

Fixes #3693

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Binder 👈 Launch a binder notebook on branch jasongrout/ipywidgets/notifications

@jasongrout
Copy link
Member Author

Looks like we're also getting a warning about an old node version in one of our actions. There is a PR open upstream for this: iFaxity/wait-on-action#6

@jasongrout
Copy link
Member Author

@martinRenou - would you like to review and merge this?

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martinRenou martinRenou merged commit 7325e59 into jupyter-widgets:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix visual regression test
2 participants