Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_append_display_data for ipython 8.11.0 #3712

Closed
wants to merge 1 commit into from

Conversation

frenzymadness
Copy link
Contributor

Fixes #3711

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Binder 👈 Launch a binder notebook on branch frenzymadness/ipywidgets/patch-2

@kellietay
Copy link

Thank you so much, we appreciate your contribution! Can you help to fix the 1 more test that failed?

@stevejpurves
Copy link
Contributor

it kind of looks like there is only one place to change the test here though, and that is the change included in this PR?
Noting that the test for python 3.10 passes (ipykernel 6.21.2) while python 3.7 fails (it loads ipykernel 6.16.2) is this because our test environment is too loose and the recent ipykernel change to string the newline isn't installed in the 3.7 environment?

@frenzymadness
Copy link
Contributor Author

IIRC the problem is that ipython 8 does not support Python 3.7 so the test for Python 3.7 installs ipython 7.34 and that version works with the old test. Should I make the test work with both major versions of ipython?

@djp52 djp52 mentioned this pull request Mar 14, 2023
@maartenbreddels
Copy link
Member

@martinRenou this explain what why we needed the fix in #3720

Thanks for the PR @frenzymadness , but we accidently re-discovered this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_append_display_data fails
4 participants