Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #3720

Merged
merged 5 commits into from
Mar 21, 2023
Merged

Fix CI #3720

merged 5 commits into from
Mar 21, 2023

Conversation

martinRenou
Copy link
Member

No description provided.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch martinRenou/ipywidgets/fix_test

@martinRenou martinRenou mentioned this pull request Mar 17, 2023
Merged
@martinRenou martinRenou marked this pull request as draft March 17, 2023 08:57
@martinRenou
Copy link
Member Author

I'm not sure what is the exact origin of the issue, but there is a mismatch in the mimebundle between Python 3.7 tests and higher versions (maybe a mismatch in IPython/ipykernel versions?)

@martinRenou martinRenou marked this pull request as ready for review March 17, 2023 09:04
@martinRenou martinRenou mentioned this pull request Mar 21, 2023
Merged
@maartenbreddels maartenbreddels merged commit 462ecd3 into jupyter-widgets:main Mar 21, 2023
@maartenbreddels
Copy link
Member

thanks!

@martinRenou martinRenou deleted the fix_test branch March 21, 2023 08:20
@martinRenou
Copy link
Member Author

@meeseeksdev please backport to 7.x

@lumberbot-app
Copy link

lumberbot-app bot commented Mar 21, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 462ecd3760cd0788af915248ecc3913a3f1e8fb6
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #3720: Fix CI'
  1. Push to a named branch:
git push YOURFORK 7.x:auto-backport-of-pr-3720-on-7.x
  1. Create a PR against branch 7.x, I would have named this PR:

"Backport PR #3720 on branch 7.x (Fix CI)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

martinRenou added a commit to martinRenou/ipywidgets that referenced this pull request Mar 21, 2023
@martinRenou
test: fix test that contained a newline, and now shouldn't (jupyter-w…
28a4437 
…idgets#3720)

could be a change in IPython/ipykernel

(cherry picked from commit 462ecd3)
martinRenou added a commit to martinRenou/ipywidgets that referenced this pull request Mar 21, 2023
@martinRenou
test: fix test that contained a newline, and now shouldn't (jupyter-w…
30d0665 
…idgets#3720)

could be a change in IPython/ipykernel

(cherry picked from commit 462ecd3)
@martinRenou martinRenou mentioned this pull request Mar 21, 2023
Merged
@maartenbreddels maartenbreddels mentioned this pull request Mar 21, 2023
Closed
martinRenou added a commit that referenced this pull request Mar 21, 2023
@martinRenou
Merge pull request #3726 from martinRenou/backport_move_comm
9042d87 
Backport #3720 and #3533 to 7.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Still Needs Manual Backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @maartenbreddels