Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove the note about mappings not working with selection widgets. #3793

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Jun 29, 2023

The documentation for Selection widgets still contained a prominent admonishment that options= could no longer be a Mapping as of ipywidgets 8.0. But #3557 undid that change, so it's no longer an issue.

This reverts commit 5a73074.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch ferdnyc/ipywidgets/mappings-work-again

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Jun 30, 2023

#3794 has the fix for CI doc builds.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@martinRenou martinRenou merged commit 06ed868 into jupyter-widgets:main Jul 31, 2023
1 of 2 checks passed
@ferdnyc ferdnyc deleted the mappings-work-again branch July 31, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants