-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ipywidgets 7 #118
Conversation
Is it only installing from source that is a problem? Or is installing the built package also a problem on Windows? |
`npm` unavailable. If you're running this command using sudo, make sure `npm` is available to sudo
rebuilding js and css failed
missing files: ['C:\\Users\\vidar\\AppData\\Local\\Temp\\pip-t91jsk8h-build\\pythreejs\\static\\extension.js', 'C:\\Users\\vidar\\AppData\\Local\\Temp\\pip-t91jsk8h-build\\pythreejs\\static\\index.js']
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "C:\Users\vidar\AppData\Local\Temp\pip-t91jsk8h-build\setup.py", line 161, in <module>
setup(**setup_args)
File "C:\Miniconda3\envs\pythreetest\lib\distutils\core.py", line 148, in setup
dist.run_commands()
File "C:\Miniconda3\envs\pythreetest\lib\distutils\dist.py", line 955, in run_commands
self.run_command(cmd)
File "C:\Miniconda3\envs\pythreetest\lib\distutils\dist.py", line 974, in run_command
cmd_obj.run()
File "C:\Users\vidar\AppData\Local\Temp\pip-t91jsk8h-build\setup.py", line 47, in run
raise e
File "C:\Users\vidar\AppData\Local\Temp\pip-t91jsk8h-build\setup.py", line 40, in run
self.distribution.run_command('jsdeps')
File "C:\Miniconda3\envs\pythreetest\lib\distutils\dist.py", line 974, in run_command
cmd_obj.run()
File "C:\Users\vidar\AppData\Local\Temp\pip-t91jsk8h-build\setup.py", line 111, in run
raise ValueError(msg)
ValueError: Missing file: C:\Users\vidar\AppData\Local\Temp\pip-t91jsk8h-build\pythreejs\static\extension.js
npm is required to build a development version of widgetsnbextension This is one of several issues that gets fixed by #83. |
Sounds like we should review/merge #83, then rebase this on top of that? |
I merged #83 and then rebased this on top of master. |
I'm able to at least install this and run the examples. The code changes also make sense to me. So at least from my point of view this is good to go! |
I just tried, and was having problems doing a |
Ah yes, I believe that feature is not available in the new code. If you'd be kind enough to contribute that feature to jupyter-packaging I will be able to quickly deploy that feature to many other projects as well! 👍 I never really got the hang of how to correctly implement that. |
…s instead of overwriting.
|
5890aaf
to
c072bb0
Compare
I think this is good to go now. I'll merge and make the release. |
Also updates version to 0.4.0
CC @vidartf