small cleanup

[MCWertGaming]

This PR some smaller things left over from #132.

[certik]

I think this is fine.

Before you merge, can you please create a better commit history? You can either squash it to one commit, or have more commits as needed, and have a nice git commit log.

For example, you can have one commit which says "use single quotes instead of double quotes", and another commit which says "Remove save_screen(), already handled by the constructor". You can write more, but at least such one line should be part of every commit. Commits like "small cleanup" are fine for development, but one should fix that before merging.

If you learn to do this, it will become second nature. It makes your code and PRs much easier for others to review and see, and it makes the git history much easier to navigate, bisect and learn what was done and why.

[MCWertGaming]

Yeah sure, I'll make it like that next time.

[certik]

@MCWertGaming I asked if you could please do it this time. Since you already merged, let's leave it like that. But please let's not merge anymore commits like "small cleanup".

[MCWertGaming]

@MCWertGaming I asked if you could please do it this time. Since you already merged, let's leave it like that. But please let's not merge anymore commits like "small cleanup".

I have squashed the comits like you said. The problem with changing commits afterward is that I'm not sure how you do it without making a new commit history by yourself and pushing it without making a force push (which creates a big warning in github). @certik

[certik]

Ah I missed that. You are right. The squash commit is ok. Sorry about that.

Yes, when I do it manually, I rewrite the commits locally and force push it into the branch. I mostly use gitlab, where it doesn't generate a warning. What warning does it generate on github? The alternative is to open a new PR with the polished commits (but that seems like an overkill for a case like this).