Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cpp-tabulate dependency to v1.5 #77

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Update cpp-tabulate dependency to v1.5 #77

merged 1 commit into from
Nov 14, 2023

Conversation

IsabelParedes
Copy link
Member

Support was added for std::string_view (p-ranav/tabulate#77) which changed the row type.

Previously:

std::vector<variant<std::string, const char*, tabulate::Table>> row;

With v1.5:

std::vector<variant<std::string, const char *, std::string_view, tabulate::Table>>

@IsabelParedes IsabelParedes changed the title Update dependency cpp-tabulate to v1.5 Update cpp-tabulate dependency to v1.5 Nov 14, 2023
@IsabelParedes IsabelParedes marked this pull request as ready for review November 14, 2023 16:37
@JohanMabille JohanMabille merged commit 1ac9e6d into jupyter-xeus:main Nov 14, 2023
12 checks passed
@IsabelParedes IsabelParedes deleted the tabulate branch November 15, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IsabelParedes @JohanMabille